feat: new MessageActions component #2543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +23.7 kB (+2.25%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
oliverlaz
reviewed
Oct 25, 2024
arnautov-anton
force-pushed
the
feat/new-message-actions-api
branch
from
6ff40f6 to
b2363e3
Compare
arnautov-anton
force-pushed
the
feat/new-message-actions-api
branch
from
70db932 to
f154cd4
Compare
arnautov-anton
commented
Oct 29, 2024
| import { defaultMessageActionSet } from './defaults'; | ||
|
|
||
| export type MessageActionSetItem = { | ||
| Component: React.ComponentType; |
There was a problem hiding this comment.
Not sure if there's a good way to enforce non-null return type - any suggestions are welcome.
oliverlaz
reviewed
Oct 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2543 +/- ##
==========================================
+ Coverage 84.78% 84.79% +0.01%
==========================================
Files 392 392
Lines 8197 8196 -1
Branches 2040 2041 +1
==========================================
Hits 6950 6950
+ Misses 960 959 -1
Partials 287 287 ☔ View full report in Codecov by Sentry. |
arnautov-anton
force-pushed
the
feat/new-message-actions-api
branch
from
300da96 to
44ca88c
Compare
oliverlaz
approved these changes
Oct 29, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 29, 2024
## [12.4.0](v12.3.0...v12.4.0) (2024-10-29) ### Features * new MessageActions component ([#2543](#2543)) ([17a1160](17a1160))
|
🎉 This PR is included in version 12.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem(s)
MessageActions/MessageOptions/MessageActionsBoxare a poorly designed set of components which we were trying to patch over the time with things likeCustomMessageActionsListbut with each new patchy addition, the component set got heavier and worse to navigate in when it came to customization.messageActionsprop onMessageListandVirtualizedMessageListcomponents allow for key/handler customization:MessageContextor use translations for different languages (the key is used as button text).CustomMessageActionsListwhich allows to render custom buttons within actions dropdown but... when buttons are rendered conditionally, the "..." is still rendered and upon clicking on it, it opens up an empty actions dropdown. This solution also does not allow to adjust "quick actions" (like reply or react).Steps Taken
From Integrator's POV
Next Steps
MessageActions_UNSTABLE