fix: get correct lastMessage and latestMessagePreview from channel state #2535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-v11 #2535 +/- ##
=============================================
Coverage 85.45% 85.46%
=============================================
Files 395 395
Lines 9136 9141 +5
Branches 2359 2493 +134
=============================================
+ Hits 7807 7812 +5
+ Misses 1125 928 -197
- Partials 204 401 +197 ☔ View full report in Codecov by Sentry. |
oliverlaz
approved these changes
Oct 15, 2024
MartinCupela
deleted the
fix/channel-preview-last-message-from-channel-state
branch
github-actions bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
## [11.24.1](v11.24.0...v11.24.1) (2024-10-15) ### Bug Fixes * get correct lastMessage and latestMessagePreview from channel state ([#2535](#2535)) ([ba6b1a3](ba6b1a3))
|
🎉 This PR is included in version 11.24.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
MartinCupela
added a commit
that referenced
this pull request
Oct 15, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
## [12.2.1](v12.2.0...v12.2.1) (2024-10-15) ### Bug Fixes * get correct lastMessage and latestMessagePreview from channel state ([#2535](#2535)) ([9dcf4f3](9dcf4f3))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Fix bug of not syncing
lastMessageandlatestMessage. Meanwhile thelatestMessagewas correctly taken from the channel state, thelastMessagewas set as any message coming withmessage.new,message.updatedandmessage.deleted. Moreover,message.undeletedandchannel.truncatewere not taken into consideration when settinglastMessage. Now both are set from thechannel.state.Another fix is that
latestMessagewas derived fromchannel.state.messageswhat is a getter that returns the currently viewed message set in the message list, but not the latest message set. This had to be changed tochannel.state.latestMessages.I have deprecated
latestMessagein favor oflatestMessagePreviewbecause for integrators (and for me) it was unclear how does it differ fromlastMessage.Finally I have added possibility to customize the possibility of generating latest message preview through new prop
getLatestMessagePreviewtoChannelListandChannelPreview.