fix: avoid eager channel pagination on channel open #2425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2425 +/- ##
==========================================
+ Coverage 85.21% 85.45% +0.23%
==========================================
Files 372 392 +20
Lines 7983 9084 +1101
Branches 1914 2347 +433
==========================================
+ Hits 6803 7763 +960
- Misses 1087 1120 +33
- Partials 93 201 +108 ☔ View full report in Codecov by Sentry. |
MartinCupela
commented
Jun 17, 2024
| @@ -93,7 +95,12 @@ export const InfiniteScroll = (props: PropsWithChildren<InfiniteScrollProps>) => | |||
| } | |||
|
|
|||
| if (isLoading) return; | |||
| // FIXME: this triggers loadMore call when a user types messages in thread and the scroll container container expands | |||
| if (previousOffset.current === offset && previousReverseOffset.current === reverseOffset) | |||
There was a problem hiding this comment.
Prevents duplicate queries when the dimensions do not change.
|
Size Change: +118 B (+0.02%) Total Size: 755 kB
ℹ️ View Unchanged
|
oliverlaz
approved these changes
Jun 19, 2024
arnautov-anton
approved these changes
Jun 21, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jun 21, 2024
## [11.22.0](v11.21.0...v11.22.0) (2024-06-21) ### Bug Fixes * adjust ChannelActionContextValue type ([#2434](#2434)) ([977ec39](977ec39)) * avoid eager channel pagination on channel open ([#2425](#2425)) ([c1e8b93](c1e8b93)) * keep line breaks in message text that contains multiple markdown elements ([#2429](#2429)) ([11e606f](11e606f)) ### Features * load lazily mp3 encoding library for audio recorder ([#2432](#2432)) ([2ca3188](2ca3188))
|
🎉 This PR is included in version 11.22.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Eager channel pagination lead to problems in Safari. More messages were queried on channel opening which increased the scroll size of the container. Safari does not adjust container scrollTop on prepending new items. The SDK logic however relies on scroll events to maintain the list scrolled to the bottom. As a result the container was not scrolled to the bottom in Safari.