feat: allow to configure date and time format over i18n #2419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinCupela
requested review from
oliverlaz,
myandrienko,
khushal87 and
arnautov-anton
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-v11 #2419 +/- ##
===============================================
+ Coverage 85.41% 85.47% +0.05%
===============================================
Files 392 392
Lines 9031 9072 +41
Branches 2326 2342 +16
===============================================
+ Hits 7714 7754 +40
- Misses 1116 1117 +1
Partials 201 201 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Anton Arnautov <[email protected]>
arnautov-anton
approved these changes
Jun 13, 2024
MartinCupela
force-pushed
the
feat/configure-datetime-format-i18n
branch
from
e940a50 to
a4e7133
Compare
MartinCupela
force-pushed
the
feat/configure-datetime-format-i18n
branch
from
a4e7133 to
daa4d4c
Compare
Co-authored-by: Anton Arnautov <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Jun 14, 2024
## [11.21.0](v11.20.0...v11.21.0) (2024-06-14) ### Bug Fixes * allow to pass minRows prop to MessageInput ([#2411](#2411)) ([e6bfd40](e6bfd40)) * memoize addNotification function provided by Channel component ([#2423](#2423)) ([b3734a4](b3734a4)) ### Features * allow to configure date and time format over i18n ([#2419](#2419)) ([cb09dc1](cb09dc1))
|
🎉 This PR is included in version 11.21.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Allow to configure date and time formatting globally.
🛠 Implementation details
To maintain backwards compatibility, the default formatting param values like
calendarandformathave been kept. The new added guide documents how to make it possible to override those from translation JSON files.