Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: memoize & add highlightDuration parameter to jumpTo[FirstUnread]Message #2414

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

arnautov-anton
Copy link
Contributor

🎯 Goal

Memoize jumpToMessage and jumpFirstUnreadMessage functions and add highlightDuration parameter.

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 26.31579% with 14 lines in your changes missing coverage. Please review.

Project coverage is 85.40%. Comparing base (ded8f05) to head (239689d).

Files Patch % Lines
src/components/Channel/Channel.tsx 22.22% 14 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-v11    #2414      +/-   ##
===============================================
- Coverage        85.41%   85.40%   -0.02%     
===============================================
  Files              392      392              
  Lines             9031     9036       +5     
  Branches          2326     2330       +4     
===============================================
+ Hits              7714     7717       +3     
- Misses            1116     1118       +2     
  Partials           201      201              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arnautov-anton arnautov-anton changed the title fix: memoize jumpToMessage and jumpFirstUnreadMessage functions feat: memoize & add highlightDuration parameter to jumpTo[FirstUnread]Message Jun 7, 2024
@arnautov-anton arnautov-anton merged commit 305d4f3 into release-v11 Jun 7, 2024
9 checks passed
@arnautov-anton arnautov-anton deleted the fix/memoize-jump-to-message-functions branch June 7, 2024 10:50
github-actions bot pushed a commit that referenced this pull request Jun 7, 2024
## [11.20.0](v11.19.0...v11.20.0) (2024-06-07)

### Bug Fixes

* make it possible to jump to system messages in MessageList ([#2404](#2404)) ([6cb81c5](6cb81c5))
* reflect separateGiphyPreview prop value in VirtualizedMessageList ([#2402](#2402)) ([5d00b56](5d00b56))
* update quoting message on update of quoted message ([#2408](#2408)) ([4ec3518](4ec3518))

### Features

* allow custom class on Modal root div ([#2410](#2410)) ([b614eff](b614eff))
* allow to customize MessageStatus UI by message delivery status ([#2405](#2405)) ([7929bc2](7929bc2))
* memoize & add highlightDuration parameter to jumpTo[FirstUnread]Message ([#2414](#2414)) ([305d4f3](305d4f3))

### Chores

* **deps:** bump stream-chat to v8.33.1 ([ded8f05](ded8f05))
@stream-ci-bot
Copy link
Collaborator

🎉 This PR is included in version 11.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants