chore: add demo of LLC without SCG #2400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myandrienko
commented
May 23, 2024
Comment on lines
+17
to
+25
| declare module 'stream-chat' { | ||
| interface UserEx { | ||
| customUserField: string; | ||
| } | ||
|
|
||
| interface ReactionEx { | ||
| customReactionField: string; | ||
| } | ||
| } |
There was a problem hiding this comment.
This is what integrators will have to do, instead of using SCG.
There was a problem hiding this comment.
This looks very nice! 🚀 Let's plan to fix this for every JS SDK
Comment on lines
+36
to
+40
| const chatClient = useCreateChatClient({ | ||
| apiKey, | ||
| tokenOrProvider: userToken, | ||
| userData: { id: userId, customUserField: 'field' }, | ||
| }); |
There was a problem hiding this comment.
Note how userData supports customUserField and doesn't cause type error. That's because useCreateChatClient uses UserResponseEx type for it.
Comment on lines
+45
to
+47
| const { reactions } = await chatClient.queryReactions('dummy', {}); | ||
| console.log(reactions[0].customReactionField); | ||
| console.log(reactions[0].user?.customUserField); |
There was a problem hiding this comment.
Similarly, queryReactions uses ReactionResponseEx type, so the response contains both customReactionField and customUserField.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start here: GetStream/stream-chat-js#1309
To try this demo locally, grab the
no-scg-demobranch fromstream-chat-jsand link it locally.