chore: Git Hooks & general cleanup #2192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.66 MB ℹ️ View Unchanged
|
|
I think that we can remove commitlint once it will not be possible to push directly to master :) |
MartinCupela
approved these changes
Nov 28, 2023
oliverlaz
approved these changes
Nov 28, 2023
arnautov-anton
force-pushed
the
chore/git-hooks-cleanup
branch
from
8259e07 to
76f0614
Compare
|
🎉 This PR is included in version 11.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Personally - not a big fan of Git Hooks - but I believe the general consensus is to keep them so I did some upgrading/cleaning up. I also removed the Python script as we're not commiting any binaries to our SDK and I'm not installing Python on my machine to run it.
Also - I'm considering ditching the
commitlintextension as all of our PR's are squashed and that commit message is being checked by the CI (Check PR title).Removed some of the other files that I believe are unused and no longer relevant.