fix(i18n): prevent removal of dynamically generated translation keys #2154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +6.69 kB (0%) Total Size: 1.91 MB
ℹ️ View Unchanged
|
oliverlaz
approved these changes
Nov 3, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Nov 3, 2023
## [10.16.1](v10.16.0...v10.16.1) (2023-11-03) ### Bug Fixes * **i18n:** prevent removal of dynamically generated translation keys ([#2154](#2154)) ([ebcaa8f](ebcaa8f))
|
🎉 This PR is included in version 10.16.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 8, 2023
## [11.0.0-rc.4](v11.0.0-rc.3...v11.0.0-rc.4) (2023-11-08) ### Bug Fixes * **i18n:** add missing SDK translations ([#2157](#2157)) ([e22a6ce](e22a6ce)) * **i18n:** do not translate command names ([#2155](#2155)) ([b654b9a](b654b9a)) * **i18n:** prevent removal of dynamically generated translation keys ([#2154](#2154)) ([ebcaa8f](ebcaa8f)) * List/Item & EmojiPicker async data loading + docs update ([dedefac](dedefac)) ### Features * add Channel prop doDeleteMessageRequest ([#2152](#2152)) ([a01774a](a01774a)) * expose channels state on chat level ([#2161](#2161)) ([7e5543b](7e5543b))
|
🎉 This PR is included in version 11.0.0-rc.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Commands menu items in the
MessageInput's autocomplete are using dynamically generated translation keys. These depend on the the permissions a user has. As i18next generates the translations at build time, it does not know that these are valid keys.Adding the dynamic keys to the comments above the translator function calls does not work in this case, because the generated values and the generated keys are the same (e.g.
"unban-command-name": "unban-command-name".Therefore we have to enable
keepRemovedoption to keep these dynamically generated keys in the translation sheets. For more see:https://github.com/i18next/i18next-parser#options