feat: add commands translations #2149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2149 +/- ##
==========================================
- Coverage 83.62% 83.61% -0.01%
==========================================
Files 307 307
Lines 7085 7093 +8
Branches 1898 1901 +3
==========================================
+ Hits 5925 5931 +6
- Misses 998 1000 +2
Partials 162 162
☔ View full report in Codecov by Sentry. |
|
Size Change: +463 B (0%) Total Size: 1.9 MB
ℹ️ View Unchanged
|
oliverlaz
approved these changes
Oct 31, 2023
|
🎉 This PR is included in version 10.16.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 2, 2023
## [11.0.0-rc.3](v11.0.0-rc.2...v11.0.0-rc.3) (2023-11-02) ### Bug Fixes * prevent flashing EmptyStateIndicator in ChannelList before the first channels page is loaded ([#2150](#2150)) ([a2a9645](a2a9645)) ### Features * add commands translations ([#2149](#2149)) ([f55c86f](f55c86f)) ### Chores * **deps:** bump @stream-io/stream-chat-css to v4-rc ([#2153](#2153)) ([030688f](030688f))
|
🎉 This PR is included in version 11.0.0-rc.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Allow integrators to provide own translations for strings displayed in the commands suggestion list items.
I have exported the type for
Streami18nconstructor options and added a new optionparseMissingKeyHandlerto override thei18next's default. I have removed the logging of missing translation key as the commands translations make use of default values that are provided by the back-end.