fix: channel.state break on going to background #2807
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Fixes a very old and prominent issue we've had in the SDK where sometimes upon a very specific queue of actions messages would stop updating in real time.
The issue is well documented in the following issues:
Despite the oneliner fix, this issue was incredibly difficult to reproduce consistently - especially because typically it would manifest differently across different integrations.
The TL;DR version of it is:
channel
logic in our low level client would fail and so we'd never receive new messages, unable to recover unless we manually trigger loading to more recent messages or simply reload the appRemoving it is completely safe as we handle the resyncing of channels elsewhere.
🛠 Implementation details
🎨 UI Changes
iOS
Android
🧪 Testing
☑️ Checklist
develop
branch