Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed CI Spotless Check #4

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

niyajali
Copy link
Contributor

@niyajali niyajali commented Aug 20, 2024

🎯 Goal

One of the issues with Spotless is that it's not compatible with the Gradle configuration cache. To solve this we need to use --no-configuration-cache and --no-daemon flags

As reported here

🛠 Implementation details

Describe the implementation details for this Pull Request.

✍️ Explain examples

Explain examples with code for this updates.

Preparing a pull request for review

Ensure your change is properly formatted by running:

$ ./gradlew spotlessApply

Please correct any failures before requesting a review.

One of the issues with Spotless is that it's not compatible with the Gradle configuration cache. To solve this we need to use --no-configuration-cache and --no-daemon flags

- diffplug/spotless#1924
@niyajali niyajali requested a review from skydoves as a code owner August 20, 2024 09:03
Copy link
Member

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! This is awesome :)

@skydoves skydoves merged commit 78bc96d into GetStream:main Aug 20, 2024
2 checks passed
@niyajali
Copy link
Contributor Author

Thank You :)

@niyajali niyajali deleted the fix-ci-spotless branch August 20, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants