Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Feature/multiple apps #9

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

WIP: Feature/multiple apps #9

wants to merge 10 commits into from

Conversation

macostea
Copy link
Contributor

  • Split argocd deployment and kustomize image update
  • Pass argocd app names and deploy dirs as stringified json arrays
  • Use prettier in the bash script with npx instead of separate step because we need to do it for multiple dirs
  • Use one-dimension matrix to sync argocd after kustomize has been run

[sc-21775]

@shortcut-integration
Copy link

@@ -44,7 +48,7 @@ jobs:
uses: rtCamp/action-slack-notify@v2
if: failure() && (github.ref_name == 'development' || github.ref_name == 'master' || github.ref_name == 'production')
env:
SLACK_CHANNEL: taas-dev
SLACK_CHANNEL: taas-github
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think failed deploys should be kept in #taas-dev

Github channel is spammed allot by github stuff and this would easily drown

required: true
type: string
deploy_dirs:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would we need multiple deploy dirs.

Can you gave a example of how the file structure would look with this change

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this will work fine too:

global service:

deploys/
  base/
  overlays/
    euc1-testing/
    euc1-staging/
    euc1/
    euw1/

sharded service:

deploys/
  base/
  overlays/
    euc1-testing/
    euc1-staging/
    euc1-shared01/
    euc1-shared02/
    euw1-agents01/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

multiple deploy dirs are for multiple apps in the same cluster

deploy-app1/
  base/
  overlays/
    euc1-testing/
deploy-app2/
  base/
  overlays/
    euc1-testing/

@MarkArts
Copy link
Contributor

Can you make a PR on a k8s app to show how it would look implemented (and show how to migrate if needed)

@macostea
Copy link
Contributor Author

Can you make a PR on a k8s app to show how it would look implemented (and show how to migrate if needed)

https://github.com/GETProtocolLab/oesophagus/pull/215

@macostea macostea changed the title Feature/multiple apps WIP: Feature/multiple apps Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants