-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Feature/multiple apps #9
base: master
Are you sure you want to change the base?
Conversation
This pull request has been linked to Shortcut Story #21775: [Workflows] shared github workflow should support deploying n apps to n clusters. |
@@ -44,7 +48,7 @@ jobs: | |||
uses: rtCamp/action-slack-notify@v2 | |||
if: failure() && (github.ref_name == 'development' || github.ref_name == 'master' || github.ref_name == 'production') | |||
env: | |||
SLACK_CHANNEL: taas-dev | |||
SLACK_CHANNEL: taas-github |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think failed deploys should be kept in #taas-dev
Github channel is spammed allot by github stuff and this would easily drown
required: true | ||
type: string | ||
deploy_dirs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would we need multiple deploy
dirs.
Can you gave a example of how the file structure would look with this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this will work fine too:
global service:
deploys/
base/
overlays/
euc1-testing/
euc1-staging/
euc1/
euw1/
sharded service:
deploys/
base/
overlays/
euc1-testing/
euc1-staging/
euc1-shared01/
euc1-shared02/
euw1-agents01/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
multiple deploy dirs are for multiple apps in the same cluster
deploy-app1/
base/
overlays/
euc1-testing/
deploy-app2/
base/
overlays/
euc1-testing/
Can you make a PR on a k8s app to show how it would look implemented (and show how to migrate if needed) |
|
[sc-21775]