Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: YK Web build #395

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Fix: YK Web build #395

merged 4 commits into from
Jan 16, 2025

Conversation

dcoric
Copy link
Collaborator

@dcoric dcoric commented Jan 15, 2025

Migrated Yunikorn Web build from package.json scripts to the make file.
Adds @types/node for setting env variables on build time.

@dcoric dcoric requested a review from sudiptob2 January 15, 2025 14:06
Copy link
Collaborator

@sudiptob2 sudiptob2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update the build/unicorn-history-server/Dockerfile ?

@dcoric dcoric force-pushed the denis-coric/yunikorn-web-build branch 2 times, most recently from bb46631 to d2178e0 Compare January 15, 2025 17:05
Migrated yk build from package.json scripts to the make file
added @types/node
@dcoric dcoric force-pushed the denis-coric/yunikorn-web-build branch 2 times, most recently from e85a2e3 to b7eaf15 Compare January 16, 2025 00:07
@dcoric dcoric force-pushed the denis-coric/yunikorn-web-build branch from b7eaf15 to 140a323 Compare January 16, 2025 00:19
@dcoric dcoric merged commit 8c43100 into main Jan 16, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants