Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended queue and partition with ID's #377

Merged
merged 5 commits into from
Jan 8, 2025
Merged

Conversation

dcoric
Copy link
Collaborator

@dcoric dcoric commented Dec 18, 2024

This pull request includes several changes to improve the allocations-drawer component and related models in the web application. The most important changes include adding a new column for elapsed time, modifying the SchedulerService to use updated API endpoints, and adding encoded references for licensing information.

Improvements to allocations-drawer component:

  • Added a new column elapsedTime to display the time taken for allocation in the allocations-drawer.component.html file.
  • Refactored the allocations-drawer.component.ts file to include a new method calculateElapsedTime for computing elapsed time.

Updates to models:

  • Added new fields requestTime and allocationTime to the AllocationInfo model.
  • Included licensing information in the app-info.model.ts, partition-info.model.ts, and queue-info.model.ts files. [1] [2] [3]

Modifications to SchedulerService:

  • Updated API endpoints in the SchedulerService to use the new base URL and endpoint paths. [1] [2]

Code formatting:

  • Reformatted code in the allocations-drawer.component.html and allocations-drawer.component.ts files for better readability. [1] [2]Added column data that is available

@dcoric dcoric requested a review from fabiovincenzi December 18, 2024 13:45
Added column data that is available
@dcoric dcoric force-pushed the denis-coric/id-and-data branch from 92fee9e to 9ce84c8 Compare December 20, 2024 12:35
Copy link
Collaborator

@fabiovincenzi fabiovincenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -23,13 +43,14 @@ To run a mock server for local development, follow these steps:
**Start the JSON Server**:

- **Using Makefile**: you can start the server by running:

```sh
make mock-server
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated, but II think this is make json-server, maybe we can fix in another PR

@dcoric dcoric merged commit 46d2e9f into main Jan 8, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants