Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pgadmin container in docker-compose. #37

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

sudiptob2
Copy link
Collaborator

@sudiptob2 sudiptob2 commented Jun 7, 2024

closes #42
A pgadmin container will allow quick and convenient lookup to the development database 😊

@sudiptob2 sudiptob2 requested a review from richscott June 7, 2024 03:28
@richscott richscott requested a review from dejanzele June 7, 2024 19:18
@sudiptob2 sudiptob2 force-pushed the feat/add-pgadmin-container branch from 2df890b to c38fd7d Compare June 11, 2024 15:27
Copy link
Collaborator

@richscott richscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion/request.

@@ -3,8 +3,6 @@ services:
container_name: postgres
image: postgres:15.2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as we're updating this file, can you update this to 15.7 ? (I think that's the latest minor release in Postgres 15).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@sudiptob2 sudiptob2 requested a review from richscott June 11, 2024 16:43
@richscott richscott merged commit 1ba9828 into G-Research:main Jun 11, 2024
6 checks passed
dejanzele pushed a commit to dejanzele/yunikorn-history-server that referenced this pull request Jun 24, 2024
* Add pgadmin container in docker-compose.

* update postgres
dejanzele pushed a commit to dejanzele/yunikorn-history-server that referenced this pull request Jun 28, 2024
* Add pgadmin container in docker-compose.

* update postgres
@sudiptob2 sudiptob2 deleted the feat/add-pgadmin-container branch July 17, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pgadmin container for quick DB lookup
3 participants