Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check-required workflow and release workflow #35

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Add check-required workflow and release workflow #35

merged 1 commit into from
Jun 7, 2024

Conversation

pavlovic-ivan
Copy link
Collaborator

@pavlovic-ivan pavlovic-ivan commented Jun 6, 2024

Description

This PR adds workflows for releasing built docker images for YHS, and a check-required workflow as in FML. There are a couple of prerequisites before merging this PR.

Prerequisites:

  • create and install a new GitHub app with the check:write permissions
  • add its credentials to a new create-check environment that can only be accessed by the main branch. Credentials are found in app settings. Look for app id, and create a private key for the app.
    • secrets should be named APP_ID and APP_PRIVATE_KEY and placed in the environment
  • Create one more environment called release also accessed by the main branch
    • add two secrets DOCKER_PASSWORD and DOCKER_USERNAME. Docker password should be a PAT generated in Docker hub. add an environment variable called DOCKER_REPO in format <docker account>/<docker repository>`

Fixes: https://github.com/G-Research/gr-oss/issues/729

@pavlovic-ivan pavlovic-ivan marked this pull request as ready for review June 6, 2024 12:25
@pavlovic-ivan pavlovic-ivan merged commit 3033c99 into G-Research:main Jun 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants