Fix UHS performance-tests target and JS test code #329
Conversation
- Fix UHS container instantiation via helm - Change 'disown' shell usage for detaching UHS process to use 'nohup' wrapper prefix instead - 'disown' is available in full Bash, but not minimal /bin/sh versions. - Remove use of 'UHS_TEST' as cluster-name - it does not appropriate to propagate correctly through the several funcion sub-shells we invoke for cluster creation, kind image loading, etc. Since we are creating the cluster and tearing it down after tests run, we should be safe with the default 'UHS' cluster name. - Fix JS test code to use UHS-style /api/v1/... API prefix, and use correct status_text for parsing response. Fixes G-Research#309
- Fix UHS container instantiation via helm - Change 'disown' shell usage for detaching UHS process to use 'nohup' wrapper prefix instead - 'disown' is available in full Bash, but not minimal /bin/sh versions. - Remove use of 'UHS_TEST' as cluster-name - it does not appropriate to propagate correctly through the several funcion sub-shells we invoke for cluster creation, kind image loading, etc. Since we are creating the cluster and tearing it down after tests run, we should be safe with the default 'UHS' cluster name. - Fix JS test code to use UHS-style /api/v1/... API prefix, and use correct status_text for parsing response. Fixes G-Research#309
…corn-history-server into rich/performance-tests-fix
Makefile
Outdated
| @@ -208,7 +208,7 @@ define start-cluster | |||
| @echo "**********************************" | |||
| @echo "Creating cluster" | |||
| @echo "**********************************" | |||
| @CLUSTER_NAME=uhs-test $(MAKE) create-cluster | |||
| $(MAKE) create-cluster | |||
There was a problem hiding this comment.
Creating a separate cluster for test seemed to be a good idea. Sometimes I keep Yunikorn running locally in a cluster and at the same time, I also want to run integration/perf test.
There was a problem hiding this comment.
Okay - reverted back in commit 70d0db9
All tests finally work now! Please re-review. |
| @@ -97,6 +97,10 @@ KIND_VERSION ?= latest | |||
| MINIKUBE ?= $(LOCALBIN_TOOLING)/minikube | |||
| MINIKUBE_VERSION ?= latest | |||
|
|
|||
| # The release version of Yunikorn images | |||
| # used in integration and performance tests. | |||
| YK_VERSION=fab384e | |||
There was a problem hiding this comment.
I just have a small question.
So, we have to change this version every time we release a YK image.
Why don't we release with the latest tag?
There was a problem hiding this comment.
I always wonder that!
There was a problem hiding this comment.
We will change this to latest after we unleash our first v1.6.0-1-gr0 (or whatever) image release, and @pavlovic-ivan can also make a latest tag alias to that.
latestonce that tag is published for yk-core.Fixes #309