Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build docker images #30

Merged
merged 4 commits into from
Jun 5, 2024
Merged

Add build docker images #30

merged 4 commits into from
Jun 5, 2024

Conversation

pavlovic-ivan
Copy link
Collaborator

@pavlovic-ivan pavlovic-ivan commented Jun 4, 2024

This PR adds steps that build docker images for amd64 and arm64.

Fixes: https://github.com/G-Research/gr-oss/issues/723

@pavlovic-ivan pavlovic-ivan requested a review from richscott June 4, 2024 11:16
Copy link
Collaborator

@richscott richscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those unrelated Go linting errors are fixed in my event-statistics PR, which needs a unit-test added and some other stuff, but that shouldn't stop the merge of this.

@pavlovic-ivan
Copy link
Collaborator Author

@richscott do i have your approval as well, on this PR?

@richscott
Copy link
Collaborator

@richscott do i have your approval as well, on this PR?

Oops, sorry - I thought I had approved earlier. Now approved.

@pavlovic-ivan pavlovic-ivan merged commit 1902ca9 into G-Research:main Jun 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants