Implement Zap logger #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richscott
requested review from
Mo-Fatah,
richscott,
dave-gantenbein and
dejanzele
sudiptob2
force-pushed
the
feat/configure-zap-logger
branch
from
926fc7a to
0485127
Compare
sudiptob2
force-pushed
the
feat/configure-zap-logger
branch
from
2be795b to
713f1ef
Compare
richscott
reviewed
Jun 13, 2024
sudiptob2
force-pushed
the
feat/configure-zap-logger
branch
from
fea44af to
f741e78
Compare
richscott
approved these changes
Jun 13, 2024
dejanzele
pushed a commit
to dejanzele/yunikorn-history-server
that referenced
this pull request
Jun 24, 2024
* initial zap logger configuration. * update the default path of yhs logs.
dejanzele
pushed a commit
to dejanzele/yunikorn-history-server
that referenced
this pull request
Jun 28, 2024
* initial zap logger configuration. * update the default path of yhs logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reviewed the implementation of
zapin theynikorn-corerepository. In this PR, I've included a trimmed-down version based on their approach. I would greatly appreciate your feedback to determine if this is something we can proceed with.Logs are saved into a file as well as into standard out.
Tasks
Output