replace uuid with ulid #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudiptob2
force-pushed
the
feat/242/use-ulid
branch
from
7a52cd3 to
3278be3
Compare
nikola-jokic
requested changes
Oct 3, 2024
There was a problem hiding this comment.
We might want to change the db model. Default is UUID which should be text
https://github.com/G-Research/yunikorn-history-server/blob/d848ae82e644b770cbc7b4a9204e5be816f27c9f/migrations/20240628155246_init-tables.up.sql#L21
sudiptob2
force-pushed
the
feat/242/use-ulid
branch
from
3278be3 to
18ea531
Compare
sudiptob2
force-pushed
the
feat/242/use-ulid
branch
from
18ea531 to
17bd252
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #242