Event Statistics: track counts of YK events by type and change-type #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, add handler for new /ws/v1/event-statistics endpoint.
Improve JSON encoding of the config.EventTypeKey struct (it is the key in the key-counts map) by implementing MarshalText(). Also, shorten the format of the rendered key to just "TYPE.CHANGE".
Also, add handler for new /ws/v1/event-statistics endpoint.
Improve JSON encoding of the config.EventTypeKey struct (it is the key in the key-counts map) by implementing MarshalText(). Also, shorten the format of the rendered key to just "TYPE.CHANGE".
…-history-server into rich/event-statistics
richscott
changed the title
pavlovic-ivan
previously approved these changes
Jun 4, 2024
dave-gantenbein
requested changes
Jun 4, 2024
Verify that GetApplication() uses default partition and queue names when not given as arguments, per its comment description.
pavlovic-ivan
approved these changes
Jun 6, 2024
dave-gantenbein
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep a set of basic statistical counts of events emitted from the yunikorn-core event stream in a map, with the key being the event's Type + ChangeType, and the value being the number of occurrences of events with that key combo.
Also introduce a new
/ws/v1/event-statisticsendpoint, which returns the current event counts in JSON-format.This is intended to be used with submissions of different permutations of YK jobs, so we can determine minimum/ average/ maximum numbers of events that are emitted by YK for a given application volume. In the future, we may expand this data into a larger set of statistics, depending on other data.
Also fix many linting errors.
Fixes #21