fix: Long Recipient Name in TxRecipientCard #1756
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dhanraj30
requested review from
luizstacio,
LuizAsFight,
helciofranco,
arthurgeron,
rodrigobranas and
nelitow
as code owners
|
Thanks for the contribution! Before we can merge this, we need @Dhanraj30 to sign the Fuel Labs Contributor License Agreement. |
LuizAsFight
requested changes
Jan 7, 2025
There was a problem hiding this comment.
hi @Dhanraj30 thanks for your contribution!
can you do 2 things?
1- put a print on PR description of how the screen is looking like
2- revert the changes from your auto formatter, like changing from ' to ". We wanna keep only changes related to code logic and not formatting
|
missing to add a changeset also, you can run |
|
should we close this one then @Dhanraj30? |
|
yes |
LuizAsFight
added a commit
that referenced
this pull request
Jan 20, 2025
Fix Long Recipent name and undo formating ref : #1756 , #1752 before changes:  after chnages the output  --------- Co-authored-by: Luiz Gomes <[email protected]> Co-authored-by: Hélcio Franco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix addresses an issue where long recipient names in the TxRecipientCard component would overflow or break the layout. The solution ensures that recipient names are properly truncated, ellipsed, or wrapped to fit within the designated space, improving the UI's appearance and functionality.