Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecation message #903

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 commented Jan 22, 2025

Related to: FuelLabs/fuels-ts#3482

Summary

Passing the module_or_path directly is deprecated, it now expects an object with the module_or_path key (reference).

Reproduction

  • Using node@22 on master, build and test and you'll encounter the following warning:

    using deprecated parameters for the initialization function; pass a single object instead

  • Using node@22 on ps/fix/deprecation-warning, build and test, the error should not be present.

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • If performance characteristic of an instruction change, update gas costs as well or make a follow-up PR for that
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

[Add or remove entries as needed]

@petertonysmith94 petertonysmith94 added the bug Something isn't working label Jan 22, 2025
@petertonysmith94 petertonysmith94 self-assigned this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant