[feature/jmt (2/4) Implementation of functions to manipulate a Jmt #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acerone85
requested review from
xgreenx,
Dentosal,
MitchTurner and
Voxelot
as code owners
netrome
reviewed
Jan 17, 2025
Comment on lines
+252
to
+259
| // Inclusion and Exclusion proof require that the root is set, hence we add it | ||
| // here. Jmt does not make the constructor for `NibblePath` accessible, so | ||
| // we add and remove a node instead. | ||
| // TODO: Find a way to set the root without adding and deleting a node | ||
| let mock_key = MerkleTreeKey::new(Bytes32::default()); | ||
| let mock_value = vec![0u8]; | ||
| tree.update(mock_key, &mock_value)?; | ||
| tree.delete(mock_key)?; |
| // We start from version 2 to be consistent with the version obtained | ||
| // when returning a new tree. | ||
| // TODO: Change Self::new so that the initial version of a new tree is 0. | ||
| let version = 2; |
There was a problem hiding this comment.
Perhaps this should be a constant
| set: I, | ||
| ) -> Result<Self, MerkleTreeError<StorageError>> | ||
| where | ||
| I: Iterator<Item = (B, D)>, |
There was a problem hiding this comment.
Nit: This could be more generic if we use IntoIterator. It saves the caller from explicitly calling .iter() or .into_iter() most of the time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds upon #891 to provide the basic functions to manipulate a jmt:
Tests are provided in the last PR of this feature.
Checklist
Before requesting review
After merging, notify other teams
[Add or remove entries as needed]