cs_convert, dbconvert: Truncate data as needed. #573
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Automatically truncate strings that would overflow their destinations, mainly for the sake of bulk insertions. * Fully honor *BINARY and IMAGE data buffer size limits in cs_convert. * Update unit tests (ctlib cs_convert, dblib t0019) accordingly. Signed-off-by: Aaron M. Ucko <[email protected]>
freddy77
reviewed
Jun 2, 2024
Comment on lines
-299
to
+300
| CS_CHAR test2[] = "ab", CS_CHAR_TYPE, test, 3, CS_CHAR_TYPE, 2, CS_FAIL, test2, 2); | ||
| CS_CHAR test2[] = "ab", CS_CHAR_TYPE, test, 3, CS_CHAR_TYPE, 2, | ||
| CS_SUCCEED /* CS_FAIL */, test2, 2); |
There was a problem hiding this comment.
I think these tests are checked against proprietary libraries. That is you are introducing a bug.
There was a problem hiding this comment.
Ah, yeah, looks like such truncation should occur only in the context of bulk insertion (where it does happen with proprietary libraries).
|
Withdrawn in favor of a (planned) extension to #558. |
|
This extension wound up with only |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #555.