Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filtering on dateOnly fields now interprets interval properly #1231

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

arnaud-moncel
Copy link
Member

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

Copy link

codeclimate bot commented Dec 18, 2024

Code Climate has analyzed commit fc93ba9 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (98% is the threshold).

This pull request will bring the total coverage in the repository to 97.2%.

View more on Code Climate.

@SteveBunlon SteveBunlon changed the title fix: dateOnly filter transform fix: filtering on dateOnly fields now interprets interval properly Dec 18, 2024
Copy link
Member

@SteveBunlon SteveBunlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Tech Review
  • Functional Review

Copy link
Member

@SteveBunlon SteveBunlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing !

@arnaud-moncel arnaud-moncel merged commit 9e359b9 into main Dec 18, 2024
22 checks passed
@arnaud-moncel arnaud-moncel deleted the fix/dataonly-transform branch December 18, 2024 15:37
forest-bot added a commit that referenced this pull request Dec 18, 2024
## [1.12.1](https://github.com/ForestAdmin/agent-nodejs/compare/[email protected]@1.12.1) (2024-12-18)

### Bug Fixes

* filtering on dateOnly fields now interprets interval properly ([#1231](#1231)) ([9e359b9](9e359b9))
forest-bot added a commit that referenced this pull request Dec 18, 2024
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.3.28 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Dec 18, 2024
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.12.1 🎉

The release is available on [email protected]

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Dec 18, 2024
forest-bot added a commit that referenced this pull request Dec 18, 2024
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.56.1 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Dec 18, 2024
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.57.1 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Dec 18, 2024
forest-bot added a commit that referenced this pull request Dec 18, 2024
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.1.43 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Dec 18, 2024
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.8.8 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Dec 18, 2024
forest-bot added a commit that referenced this pull request Dec 18, 2024
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.5.8 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Dec 18, 2024
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.11.3 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Dec 18, 2024
forest-bot added a commit that referenced this pull request Dec 18, 2024
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.16.3 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants