Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(native-query): execute chart query requests #1225

Merged
merged 14 commits into from
Dec 18, 2024
Merged

feat(native-query): execute chart query requests #1225

merged 14 commits into from
Dec 18, 2024

Conversation

DayTF
Copy link
Contributor

@DayTF DayTF commented Dec 6, 2024 •
edited
Loading

Definition of Done

CU-86c12d395 CU-86c12d3az

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@forest-bot
Copy link
Member

Task linked: CU-86c12d395 Story #2 - Users want native query charts
Task linked: CU-86c12d3az Story #3 - Users want native query analytics charts

@DayTF DayTF force-pushed the feat/capabilities/native-query branch from 67aa599 to 8e576ed Compare December 12, 2024 15:54
DayTF
DayTF commented Dec 13, 2024
View reviewed changes
packages/agent/src/routes/access/native-query-datasource.ts

break;
default:
throw new Error('Unknown Chart type');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested because it is not possible due to isQueryChartRequest check

@DayTF DayTF force-pushed the feat/capabilities/native-query branch from 202f8e8 to 4f543ac Compare December 16, 2024 10:10
@DayTF DayTF force-pushed the feat/capabilities/native-query branch from ab95bff to 6ee9408 Compare December 16, 2024 17:39
@codeclimate CodeClimate
Copy link

codeclimate bot commented Dec 17, 2024

Code Climate has analyzed commit de29365 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 99.0% (98% is the threshold).

This pull request will bring the total coverage in the repository to 97.2% (0.0% change).

View more on Code Climate.

realSpok
realSpok approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@realSpok realSpok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ✅ PR title

  • ✅ PR linked to the clickup task

  • ✅ The PR tackle one subject only

  • ✅ Destination branch

  • ✅ Code review

    • ✅ Use pure functions when possible
    • ✅ Performance concerns
    • ✅ Security concerns

  • ✅ Automatic tests

    • ✅ Unit tests
    • ✅ Integration tests

  • ✅ Manual tests

    • ✅ Test the functionality
    • ✅ Test error cases

@DayTF DayTF merged commit 84b26dd into main Dec 18, 2024
22 checks passed
@DayTF DayTF deleted the feat/capabilities/native-query branch December 18, 2024 13:00
forest-bot added a commit that referenced this pull request Dec 18, 2024
@forest-bot
chore(release): [email protected] [skip ci]
9161eaa 
# [1.12.0](https://github.com/ForestAdmin/agent-nodejs/compare/[email protected]@1.12.0) (2024-12-18)

### Bug Fixes

* **export-advanced:** compute filename on runtime ([#1229](#1229)) ([44082e8](44082e8))
* **security:** patch mongoose dependency vulnerabilities ([#1224](#1224)) ([d6197a9](d6197a9))
* **security:** patch path-to-regexp dependency vulnerabilities ([#1227](#1227)) ([839a4f3](839a4f3))

### Features

* **native-query:** execute chart query requests ([#1225](#1225)) ([84b26dd](84b26dd))
forest-bot added a commit that referenced this pull request Dec 18, 2024
@forest-bot
chore(release): @forestadmin/[email protected] [skip ci]
c32505e 
# [1.56.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-12-18)

### Bug Fixes

* **export-advanced:** compute filename on runtime ([#1229](#1229)) ([44082e8](44082e8))
* **security:** patch mongoose dependency vulnerabilities ([#1224](#1224)) ([d6197a9](d6197a9))
* **security:** patch path-to-regexp dependency vulnerabilities ([#1227](#1227)) ([839a4f3](839a4f3))
* **sequelize-ds:** allow user to create a record when there is a virtual field by removing it from the returned record ([#1223](#1223)) ([a7cb4da](a7cb4da))

### Features

* **native-query:** execute chart query requests ([#1225](#1225)) ([84b26dd](84b26dd))
forest-bot added a commit that referenced this pull request Dec 18, 2024
@forest-bot
chore(release): @forestadmin/[email protected] [skip ci]
9c7f8cc 
# [1.57.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-12-18)

### Bug Fixes

* **export-advanced:** compute filename on runtime ([#1229](#1229)) ([44082e8](44082e8))
* introduce agentCapabilities sub object ([#1222](#1222)) ([bce04f9](bce04f9))
* **security:** patch mongoose dependency vulnerabilities ([#1224](#1224)) ([d6197a9](d6197a9))
* **security:** patch path-to-regexp dependency vulnerabilities ([#1227](#1227)) ([839a4f3](839a4f3))
* **sequelize-ds:** allow user to create a record when there is a virtual field by removing it from the returned record ([#1223](#1223)) ([a7cb4da](a7cb4da))

### Features

* **capabilities:** add capabilities on get one projection ([#1221](#1221)) ([0909eaf](0909eaf))
* **native-query:** execute chart query requests ([#1225](#1225)) ([84b26dd](84b26dd))
forest-bot added a commit that referenced this pull request Dec 18, 2024
@forest-bot
chore(release): @forestadmin/[email protected] [skip ci]
3049d44 
## [1.1.42](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-12-18)

### Bug Fixes

* **export-advanced:** compute filename on runtime ([#1229](#1229)) ([44082e8](44082e8))
* introduce agentCapabilities sub object ([#1222](#1222)) ([bce04f9](bce04f9))
* **security:** patch mongoose dependency vulnerabilities ([#1224](#1224)) ([d6197a9](d6197a9))
* **security:** patch path-to-regexp dependency vulnerabilities ([#1227](#1227)) ([839a4f3](839a4f3))
* **sequelize-ds:** allow user to create a record when there is a virtual field by removing it from the returned record ([#1223](#1223)) ([a7cb4da](a7cb4da))

### Features

* **capabilities:** add capabilities on get one projection ([#1221](#1221)) ([0909eaf](0909eaf))
* **native-query:** execute chart query requests ([#1225](#1225)) ([84b26dd](84b26dd))
forest-bot added a commit that referenced this pull request Dec 18, 2024
@forest-bot
chore(release): @forestadmin/[email protected] [skip ci]
edea3f6 
## [1.8.7](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-12-18)

### Bug Fixes

* **export-advanced:** compute filename on runtime ([#1229](#1229)) ([44082e8](44082e8))
* introduce agentCapabilities sub object ([#1222](#1222)) ([bce04f9](bce04f9))
* **security:** patch mongoose dependency vulnerabilities ([#1224](#1224)) ([d6197a9](d6197a9))
* **security:** patch path-to-regexp dependency vulnerabilities ([#1227](#1227)) ([839a4f3](839a4f3))
* **sequelize-ds:** allow user to create a record when there is a virtual field by removing it from the returned record ([#1223](#1223)) ([a7cb4da](a7cb4da))

### Features

* **capabilities:** add capabilities on get one projection ([#1221](#1221)) ([0909eaf](0909eaf))
* **native-query:** execute chart query requests ([#1225](#1225)) ([84b26dd](84b26dd))
forest-bot added a commit that referenced this pull request Dec 18, 2024
@forest-bot
chore(release): @forestadmin/[email protected] [skip ci]
d7b885f 
## [1.5.7](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-12-18)

### Bug Fixes

* **export-advanced:** compute filename on runtime ([#1229](#1229)) ([44082e8](44082e8))
* **security:** patch mongoose dependency vulnerabilities ([#1224](#1224)) ([d6197a9](d6197a9))
* **security:** patch path-to-regexp dependency vulnerabilities ([#1227](#1227)) ([839a4f3](839a4f3))

### Features

* **native-query:** execute chart query requests ([#1225](#1225)) ([84b26dd](84b26dd))
forest-bot added a commit that referenced this pull request Dec 18, 2024
@forest-bot
chore(release): @forestadmin/[email protected] [skip ci]
cfed489 
## [1.11.2](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-12-18)

### Bug Fixes

* **export-advanced:** compute filename on runtime ([#1229](#1229)) ([44082e8](44082e8))
* **security:** patch mongoose dependency vulnerabilities ([#1224](#1224)) ([d6197a9](d6197a9))
* **security:** patch path-to-regexp dependency vulnerabilities ([#1227](#1227)) ([839a4f3](839a4f3))

### Features

* **native-query:** execute chart query requests ([#1225](#1225)) ([84b26dd](84b26dd))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.3.27 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Dec 18, 2024
@forest-bot
chore(release): @forestadmin/[email protected] [skip ci]
3f248e4 
## [1.16.2](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-12-18)

### Bug Fixes

* **export-advanced:** compute filename on runtime ([#1229](#1229)) ([44082e8](44082e8))
* **security:** patch mongoose dependency vulnerabilities ([#1224](#1224)) ([d6197a9](d6197a9))
* **security:** patch path-to-regexp dependency vulnerabilities ([#1227](#1227)) ([839a4f3](839a4f3))

### Features

* **native-query:** execute chart query requests ([#1225](#1225)) ([84b26dd](84b26dd))
forest-bot added a commit that referenced this pull request Dec 18, 2024
@forest-bot
chore(release): @forestadmin/[email protected] [skip ci]
e567a54 
# [1.45.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-12-18)

### Bug Fixes

* **export-advanced:** compute filename on runtime ([#1229](#1229)) ([44082e8](44082e8))
* introduce agentCapabilities sub object ([#1222](#1222)) ([bce04f9](bce04f9))
* **security:** patch mongoose dependency vulnerabilities ([#1224](#1224)) ([d6197a9](d6197a9))
* **security:** patch path-to-regexp dependency vulnerabilities ([#1227](#1227)) ([839a4f3](839a4f3))
* **sequelize-ds:** allow user to create a record when there is a virtual field by removing it from the returned record ([#1223](#1223)) ([a7cb4da](a7cb4da))

### Features

* **capabilities:** add capabilities on get one projection ([#1221](#1221)) ([0909eaf](0909eaf))
* **native-query:** execute chart query requests ([#1225](#1225)) ([84b26dd](84b26dd))
forest-bot added a commit that referenced this pull request Dec 18, 2024
@forest-bot
chore(release): @forestadmin/[email protected] [skip ci]
b4122dd 
## [1.12.11](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-12-18)

### Bug Fixes

* **export-advanced:** compute filename on runtime ([#1229](#1229)) ([44082e8](44082e8))
* **security:** patch mongoose dependency vulnerabilities ([#1224](#1224)) ([d6197a9](d6197a9))
* **security:** patch path-to-regexp dependency vulnerabilities ([#1227](#1227)) ([839a4f3](839a4f3))

### Features

* **native-query:** execute chart query requests ([#1225](#1225)) ([84b26dd](84b26dd))
forest-bot added a commit that referenced this pull request Dec 18, 2024
@forest-bot
chore(release): @forestadmin/[email protected] [skip ci]
a47f413 
# [1.36.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-12-18)

### Bug Fixes

* **export-advanced:** compute filename on runtime ([#1229](#1229)) ([44082e8](44082e8))
* introduce agentCapabilities sub object ([#1222](#1222)) ([bce04f9](bce04f9))
* **security:** patch mongoose dependency vulnerabilities ([#1224](#1224)) ([d6197a9](d6197a9))
* **security:** patch path-to-regexp dependency vulnerabilities ([#1227](#1227)) ([839a4f3](839a4f3))
* **sequelize-ds:** allow user to create a record when there is a virtual field by removing it from the returned record ([#1223](#1223)) ([a7cb4da](a7cb4da))

### Features

* **capabilities:** add capabilities on get one projection ([#1221](#1221)) ([0909eaf](0909eaf))
* **native-query:** execute chart query requests ([#1225](#1225)) ([84b26dd](84b26dd))
forest-bot added a commit that referenced this pull request Dec 18, 2024
@forest-bot
chore(release): @forestadmin/[email protected] [skip ci]
73502d0 
## [1.4.10](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-12-18)

### Bug Fixes

* **export-advanced:** compute filename on runtime ([#1229](#1229)) ([44082e8](44082e8))
* introduce agentCapabilities sub object ([#1222](#1222)) ([bce04f9](bce04f9))
* **security:** patch mongoose dependency vulnerabilities ([#1224](#1224)) ([d6197a9](d6197a9))
* **security:** patch path-to-regexp dependency vulnerabilities ([#1227](#1227)) ([839a4f3](839a4f3))
* **sequelize-ds:** allow user to create a record when there is a virtual field by removing it from the returned record ([#1223](#1223)) ([a7cb4da](a7cb4da))

### Features

* **capabilities:** add capabilities on get one projection ([#1221](#1221)) ([0909eaf](0909eaf))
* **native-query:** execute chart query requests ([#1225](#1225)) ([84b26dd](84b26dd))
forest-bot added a commit that referenced this pull request Dec 18, 2024
@forest-bot
chore(release): @forestadmin/[email protected] [skip ci]
a20e665 
## [1.1.16](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-12-18)

### Features

* **native-query:** execute chart query requests ([#1225](#1225)) ([84b26dd](84b26dd))
forest-bot added a commit that referenced this pull request Dec 18, 2024
@forest-bot
chore(release): @forestadmin/[email protected] [skip ci]
e630744 
# [1.4.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-12-18)

### Bug Fixes

* **export-advanced:** compute filename on runtime ([#1229](#1229)) ([44082e8](44082e8))
* introduce agentCapabilities sub object ([#1222](#1222)) ([bce04f9](bce04f9))
* **security:** patch mongoose dependency vulnerabilities ([#1224](#1224)) ([d6197a9](d6197a9))
* **security:** patch path-to-regexp dependency vulnerabilities ([#1227](#1227)) ([839a4f3](839a4f3))
* **sequelize-ds:** allow user to create a record when there is a virtual field by removing it from the returned record ([#1223](#1223)) ([a7cb4da](a7cb4da))

### Features

* **capabilities:** add capabilities on get one projection ([#1221](#1221)) ([0909eaf](0909eaf))
* **native-query:** execute chart query requests ([#1225](#1225)) ([84b26dd](84b26dd))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.12.0 🎉

The release is available on [email protected]

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.56.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.57.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.1.42 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.8.7 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.5.7 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.11.2 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.16.2 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.45.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.12.11 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.36.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.4.10 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.1.16 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.4.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realSpok realSpok realSpok approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DayTF @forest-bot @realSpok