Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve parity between shelf and flutter #983

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

mcquenji
Copy link

@mcquenji mcquenji commented Jan 2, 2025

Description

This PR aims to make modules written with modular_core to work in shelf and flutter.
Also has #963 merged.

  • Remove dependency overrides in pubspec.yaml review passes

Routing Mechanism Improvements:

Class Enhancements:

These changes collectively enhance the routing capabilities, ensure compatibility with the latest dependencies, and improve the overall code quality and maintainability.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

shelf_modular now uses the same builder methods for binds instead of a getter.

  • [x ] Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

#963
#968

* Fix: Pop child routes when parent route is popped

* + Added unit test for parent/child route handling

---------

Co-authored-by: zssnyder <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant