BUGFIX: Don’t include asset variants in counts #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To fix this I had to add a join to the count query to check the type of asset. I need to check whether this hurts performance in my larger projects and maybe adjust the query. |
|
So this hurts performance with a large numbers of assets. I have to see whether I find a better solution. |
This problem appeared due to variants getting the same collection applied as their original asset in neos/neos-development-collection#3562 Fixes: #224
Sebobo
force-pushed
the
bugfix/dont-count-variants
branch
from
a150e0f to
1221c4a
Compare
|
So I updated the implementation with a sub select instead of a join. This still hurts performance, but it's about 3x faster than the JOIN on the asset table to check the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This problem appeared due to variants getting the same collection applied as their original asset in neos/neos-development-collection#3562
Fixes: #224