Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid recursive store for String #2263

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Avoid recursive store for String #2263

wants to merge 2 commits into from

Conversation

vchuravy
Copy link
Member

@wsmoses unsure how to test this:

I did hit:

Trixi.TreeMesh{2, Trixi.SerialTree{2, Float64}, Float64}
Trixi.SerialTree{2, Float64}
String
ERROR: AssertionError: fieldcount(Ty) != 0
Stacktrace:
  [1] create_recursive_stores(B::LLVM.IRBuilder, Ty::DataType, prev::LLVM.Value)
    @ Enzyme.Compiler ~/src/Enzyme/src/compiler.jl:614
  [2] create_recursive_stores(B::LLVM.IRBuilder, Ty::DataType, prev::LLVM.Value)
    @ Enzyme.Compiler ~/src/Enzyme/src/compiler.jl:658
  [3] shadow_alloc_rewrite(V::Ptr{…}, gutils::Ptr{…}, Orig::Ptr{…}, idx::UInt64, prev::Ptr{…}, used::UInt8)
   `` @ Enzyme.Compiler ~/src/Enzyme/src/compiler.jl:703

Copy link
Contributor

github-actions bot commented Jan 13, 2025

Benchmark Results

main 75f18b7... main/75f18b724a7b1f...
basics/overhead 5.26 ± 0.01 ns 5.87 ± 0.011 ns 0.896
time_to_load 1.11 ± 0.0032 s 1.11 ± 0.0019 s 0.997

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant