[Community] handle candles history fetch #2449
Conversation
GuillaumeDSM
force-pushed
the
candles_db
branch
from
c7428ad to
c4c55a6
Compare
GuillaumeDSM
changed the title
| .eq( | ||
| "exchange_internal_name", exchange | ||
| ).eq( | ||
| "symbol", symbol | ||
| ).eq( | ||
| "time_frame", time_frame.value |
There was a problem hiding this comment.
You can use match instead of multiple eq
| total_candles = [] | ||
| max_requests_count = 100 | ||
| request_count = 0 | ||
| while request_count < max_requests_count: |
There was a problem hiding this comment.
Why do we need to do multiple requests?
There was a problem hiding this comment.
supabases has a max of rows returned by one query (1000 by default), here we want approx 18k rows for 15min over 6m
There was a problem hiding this comment.
And why not increasing supabase's limit?
There was a problem hiding this comment.
according to supabase this value should not be too high as it can take a lot of computing power from the db and be an attack vector. We can increase it though, this code will just adapt
There was a problem hiding this comment.
Ok thanks for the explanation 👍
GuillaumeDSM
force-pushed
the
candles_db
branch
from
90726e8 to
c82f1ee
Compare
| total_candles = [] | ||
| max_requests_count = 100 | ||
| request_count = 0 | ||
| while request_count < max_requests_count: |
There was a problem hiding this comment.
Should we catch if a request fails to not stop the whole loop or it's ok to raise?
There was a problem hiding this comment.
we would need a retry mechanism. I havn't seen it happen yet, do you think we should add it ?
There was a problem hiding this comment.
We can probably wait for it to happen a first time
requries Drakkar-Software/OctoBot-Trading#993