T1261532: DataGrid - FocusedRowChanged event isn't raised when the push API is used to remove the last row #28687
Conversation
…_25_1 # Conflicts: # e2e/testcafe-devextreme/tests/dataGrid/focus/focus.ts
| await t | ||
| .expect(Selector('#otherContainer').innerText) | ||
| .eql('Success'); |
There was a problem hiding this comment.
I feel strange about the checking the text of #otherContainer. Is it possible to use this instead of setting text in onFocusedRowChanged?
| await t | |
| .expect(Selector('#otherContainer').innerText) | |
| .eql('Success'); | |
| const key = await grid.option('focusedRowKey'); | |
| const index = await grid.option('focusedRowIndex'); | |
| await t.expect(key === null && index === -1).ok(); |
There was a problem hiding this comment.
TestCafe is designed to work with markup, and in our tests, we use the Page Object Model for the DataGrid, which operates with a markup (CCS classes and DOM elements) and does not have a method for retrieving options from the business object. It seems that transforming the state into markup and verifying it using TestCafe is the most appropriate and natural approach.
There was a problem hiding this comment.
Seems that we can retrieve options from the datagrid.
There was a problem hiding this comment.
the current test implementation does its job, but it just feels unnaturally to me to do it like that. If using grid.option() will also do the job, then I suggest to use it 🙂
There was a problem hiding this comment.
Yep, finally I see, thank you! The correct check looks slightly different)
The whole expression should be wrapped to the "except" method so the expression could calculate continuously, not only once while a declaration.
No description provided.