Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Update auth and order API versions #564

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

ihor-chaban
Copy link

@ihor-chaban ihor-chaban commented Dec 2, 2024

Updated auth (v4 to v5) and order (v7 to v8) API versions according to ahivert/tgtg-python@80859da
This fixes the broken reservations issue #531 and other potential issues related to orders.
Docker images I used for testing are available at gorus5/tgtg-scanner:latest-api and gorus5/tgtg-scanner:latest-alpine-api (multi-arch).
Reservations and orders worked fine, and I could create an order successfully.

Pull Request Checklist

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Did you make your Pull Request on the dev branch?
  • Does your submission pass tests? make test
  • Have you lint your code locally prior to submission? make lint
  • Could you build and run the docker images successfully? make images
  • Could you create a running executable? make executable
  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran manual tests with your changes locally?

@ihor-chaban ihor-chaban changed the title Update auth and order API versions [Fix] Update auth and order API versions Dec 9, 2024
@ihor-chaban ihor-chaban changed the base branch from main to dev December 23, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant