Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with pdf viewer #682

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

joandste
Copy link

@joandste joandste commented Jan 2, 2025

Closes #633, Closes #634

@joandste joandste marked this pull request as ready for review January 2, 2025 19:13
@joandste joandste linked an issue Jan 2, 2025 that may be closed by this pull request
@keanderss
Copy link
Contributor

Currently when viewing a document that has an even page count the page ordering isn't retained when going backwards and the second page won't be displayed at all. For documents with an odd page count everything works as intended. The changes make it so that this behaviour is now flipped and will break documents with an odd page count in the same way while fixing it for documents with an even page count.

@joandste
Copy link
Author

joandste commented Jan 3, 2025

Yeah sorry, i just assumed we were going to always use even pages, because then it will always be possible to show the front and backcover as a single page

Im guessing we want to show a double view on the last page if document has an odd number of pages?

Though books cant have an odd number of pages.

@keanderss
Copy link
Contributor

For the current use case of the publications app it won't be a problem as it is only used for UpDaTe but this could change in the future.

@jaspnas jaspnas requested a review from Theoabw January 3, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: zoom interaction in publications fix: publications last page back not working correctly
2 participants