[CECO-1860][DatadogGenericResource] Refactor handler #1634
+154
−158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbavelier
commented
Jan 20, 2025
| @@ -65,6 +66,9 @@ func Test_handleFinalizer(t *testing.T) { | |||
| Finalizers: []string{datadogGenericResourceFinalizer}, | |||
| DeletionTimestamp: &metaNow, | |||
| }, | |||
| Spec: datadoghqv1alpha1.DatadogGenericResourceSpec{ | |||
There was a problem hiding this comment.
This is necessary as the switch case for deletion handler now panics on unsupported/empty resource type
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1634 +/- ##
==========================================
+ Coverage 48.93% 48.96% +0.02%
==========================================
Files 217 217
Lines 20892 20880 -12
==========================================
Hits 10223 10223
+ Misses 10129 10117 -12
Partials 540 540
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Slightly refactors GenericResource controller to use interfaces avoiding code duplication and improving readability+maintenance
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Same instructions as #1534, can use
config/samples/datadoghq_v1alpha1_datadoggenericresource.yamlChecklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel