Add ECS Fargate Integration #120
Conversation
| "Name": "datadog", | ||
| "Host": "http-intake.logs.datadoghq.com", | ||
| "dd_service": options.service, | ||
| "dd_source": container.containerName, |
There was a problem hiding this comment.
It would be better if this could be set as a separate option. It's often useful to set this to nodejs or ruby to leverage the standard log processing pipelines
There was a problem hiding this comment.
Good call. Not sure the best way to define this. Might need to be passed as a separate mapping in a param in the method? Or maybe we could use metadata?
|
@astuyve Bump? |
|
hi @automartin5000 - thanks for reaching out. The Datadog CDK construct spans multiple teams internally here at Datadog, so I've reached out to the team which owns Fargate for feedback on this PR. Thanks! |
Thanks! |
|
Any update? 😄 |
|
Hi @clamoriniere, is your team the best team to review this PR? |
|
@levan-m's team is the team responsible for this repository. |
|
FWIW, I've now rewritten this code several times in the couple years since this was opened 😅 and think I have it down pretty well to easily update here if desired. |
|
@automartin5000, appreciate your contribution and sorry we weren't able to review it so far. Unfortunately Container Ecosystems team has not been investing in CDK support and lack the expertise to properly evaluate and review this change. |
What does this PR do?
Adds ECS Fargate task integration for APM, Logging, and infrastructure monitoring via the DD Agent and Fluenbit
Motivation
Wanted a standard, easy solution for adding Datadog integration to a Fargate task
Testing Guidelines
Not yet tested. Wanted to see if this is a PR that would be accepted before completing it.
Additional Notes
Happy to complete this if you guys are interested in accepting it.
Types of Changes
Check all that apply
Closes #105