-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ [RUM-8123] Introduce a hook to assemble events #3289
base: main
Are you sure you want to change the base?
Conversation
const commonContext = savedCommonContext || getCommonContext() | ||
const actionId = actionContexts.findActionId(startTime) | ||
|
||
const rumContext: RumContext = { | ||
const rumContext: Partial<CommonProperties> = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change unrelated to the PR, but we can remove RumContext
and directly use the CommonProperties
type generated by the rum-event-format
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3289 +/- ##
==========================================
+ Coverage 93.68% 93.71% +0.02%
==========================================
Files 288 289 +1
Lines 7617 7633 +16
Branches 1739 1740 +1
==========================================
+ Hits 7136 7153 +17
+ Misses 481 480 -1 ☔ View full report in Codecov by Sentry. |
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
Motivation
The overall goal is to create a Modular SDK to simplify contributions and enhance extensibility.
This PR introduces a hook system, initially used to
decouple event assembly
. Each collection module can now independently handle the assembly of its own properties.Changes
Testing
I have gone over the contributing documentation.