-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚗ [RUM-7213] DOM mutation ignoring #3276
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3276 +/- ##
==========================================
- Coverage 93.66% 93.53% -0.14%
==========================================
Files 288 288
Lines 7598 7613 +15
Branches 1730 1736 +6
==========================================
+ Hits 7117 7121 +4
- Misses 481 492 +11 ☔ View full report in Codecov by Sentry. |
function domMutationSpec( | ||
mutate: (root: HTMLElement) => void, | ||
{ expectedMutations }: { expectedMutations: number }, | ||
isRootMutationsIgnored?: boolean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This parameter allows us to test the case where the experimental feature is enabled and the IGNORE_MUTATIONS_ATTRIBUTE
is not present.
If you think it would be useful, I am also open to adding tests for the case where the experimental feature is not enabled and the IGNORE_MUTATIONS_ATTRIBUTE
is present
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
/to-staging |
Devflow running:
|
Integrated commit sha: 75388df Co-authored-by: jordan-th <[email protected]>
Motivation
Ability to exclude certain DOM mutations from affecting the page loading time calculation
Changes
attributes
mutations are ignored if the element has the attributedd-ignore-mutations
childList
andcharacterData
mutations are ignored if the parent element has the attributedd-ignore-mutations
Testing
I have gone over the contributing documentation.