-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👷 Update react monorepo to v19 (major) #3201
base: main
Are you sure you want to change the base?
Conversation
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
b15b47f
to
cd580dd
Compare
73bd79d
to
8155485
Compare
c95f28b
to
a916a1d
Compare
a916a1d
to
ff022b0
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
@@ -16,7 +16,7 @@ | |||
"@datadog/browser-rum-core": "5.35.0" | |||
}, | |||
"peerDependencies": { | |||
"react": "18", | |||
"react": "18 || 19", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ question: Can you explain why 18 || 19? My guess is not break customer integrations using v18? Does it means we have to do it for every new major version of React?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(discussed IRL, but for the record:)
- Renovate did this change automatically
- It indicates that the react plugin supports both react 18 and 19. It probably support anterior versions but I didn't test it.
- We'll need to add a new version for every major version of react, which should not be a big deal.
- It will also allow us to drop support for old react versions when it proves to be unmaintainable.
- Ideally we should run the unit tests for each version of react, or at least the oldest we support, to make sure we don't inadvertently break old versions support... but it would be a challenge to implement with our current unit test setup, so let's keep it in mind when we drop karma.
Some react ecosystem dependencies are failing raising typecheck errors. Let's skip lib check as it's not relevant for our project.
This PR contains the following updates:
18.3.18
->19.0.3
18.3.5
->19.0.2
18
->18 || 19
18.3.1
->19.0.0
18.3.1
->19.0.0
Release Notes
facebook/react (react)
v19.0.0
Compare Source
facebook/react (react-dom)
v19.0.0
Compare Source
Configuration
📅 Schedule: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.