Fixed bug where Lat/Lon/Radius point corrections are wrong in points.csv when running a rectangular (XYZ) bundle adjustment #5688
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When performing a rectangular (XYZ) bundle adjustment, the Lat/Lon/Radius point corrections written to the points.csv file are incorrect and do not match those written to the bundleout.txt file.
Fixed the method BundleSolutionInfo::outputPointsCSV() so that the code to write point corrections matches that in BundleControlPoint::formatBundleLatitudinalOutputDetailString. Also modified the ctest FunctionalTestJigsawBundleXYZ to exercise this fix by spot checking six lines (points) in points.csv.
Related Issue
#5646
How Has This Been Validated?
All jigsaw/bundle related tests continue to pass, including the updated test FunctionalTestJigsawBundleXYZ.
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: