Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move fortran debug flag #1335

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Move fortran debug flag #1335

merged 3 commits into from
Jan 7, 2025

Conversation

Davknapp
Copy link
Collaborator

@Davknapp Davknapp commented Jan 7, 2025

I think that this option is not properly parsed to the configure command. Moving it to the CONFIG_OPTIONS variable hopefully solves this issue.

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one)

Tag Label

  • The author added the patch/minor/major label in accordance to semantic versioning.

I think that this option is not properly parsed to the configure command.
Moving it to the CONFIG_OPTIONS variable hopefully solves this issue.
@Davknapp Davknapp added tests priority: high Should be solved as soon as possible workload: low Would take half a day or less Fortran tag: patch Merging this needs a new patch tag labels Jan 7, 2025
@Davknapp Davknapp changed the base branch from main to fix_fortran_interface January 7, 2025 10:30
@Davknapp Davknapp added CI Continuous Integration Follow-up PR labels Jan 7, 2025
@jmark jmark merged commit dc63ff8 into fix_fortran_interface Jan 7, 2025
20 checks passed
@jmark jmark deleted the fix-api_workflow branch January 7, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Follow-up PR Fortran priority: high Should be solved as soon as possible tag: patch Merging this needs a new patch tag tests workload: low Would take half a day or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants