Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: translation string #980

Merged
merged 1 commit into from
Oct 23, 2024
Merged

fix: translation string #980

merged 1 commit into from
Oct 23, 2024

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Sep 27, 2024 •
edited
Loading

Summary

Changes:

  • add missing translator comments
  • add localization for upgrade URLs

Generated .pot file: feedzy-free.pot.zip (with command wp i18n make-pot . languages/feedzy-free.pot)

Will affect visual aspect of the product

NO

Test instructions

  • Check if the strings and upgrade URL are in the correct format.

Check before Pull Request is ready:

Closes #978

@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Sep 27, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Sep 27, 2024
@pirate-bot pirate-bot added pr-checklist-complete The Pull Request checklist is complete. (automatic label) labels Sep 27, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel linked an issue Sep 27, 2024 that may be closed by this pull request
Prepare the plugin for localization #978
Open
@pirate-bot
Copy link
Contributor

pirate-bot commented Sep 27, 2024 •
edited
Loading

Plugin build for bffe585 is ready 🛎️!

@Soare-Robert-Daniel Soare-Robert-Daniel force-pushed the fix/translations branch 5 times, most recently from b89cd19 to 319f524 Compare October 9, 2024 13:34
abaicus
abaicus requested changes Oct 21, 2024
View reviewed changes
js/FeedBack/feedback.js Outdated Show resolved Hide resolved
@Soare-Robert-Daniel Soare-Robert-Daniel merged commit 1373e69 into development Oct 23, 2024
8 checks passed
@Soare-Robert-Daniel Soare-Robert-Daniel deleted the fix/translations branch October 23, 2024 13:35
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 4.4.14 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abaicus abaicus Awaiting requested review from abaicus

Assignees

@Soare-Robert-Daniel Soare-Robert-Daniel

Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prepare the plugin for localization
3 participants
@Soare-Robert-Daniel @pirate-bot @abaicus