Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add ESLint config file and deps #1027

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Dec 13, 2024

Summary

  • Install WordPress eslint plugin and eslint using --legacy-peer-deps to avoid conflicts with wp-scripts
  • Add EsLint config file in which non-essential rules are marked as warn instead of error.
  • Small clean-up for some rules.
  • Enabling the lint check on GA

Will affect visual aspect of the product

NO

Screenshots

Test instructions

  • Check if the build is alright

Check before Pull Request is ready:

Closes #978

@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Dec 13, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Dec 13, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel linked an issue Dec 13, 2024 that may be closed by this pull request
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review December 13, 2024 13:03
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Dec 13, 2024
@pirate-bot
Copy link
Contributor

Plugin build for 06966c6 is ready 🛎️!

@selul selul merged commit 9b379bd into development Dec 16, 2024
13 checks passed
@selul selul deleted the chore/estlint-config branch December 16, 2024 15:32
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 5.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare the plugin for localization
4 participants