-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Xcode 16 and synchronized groups #985
Add support for Xcode 16 and synchronized groups #985
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Brett-Best and @gui17aume both for contributing this 🙏
I'm going to do some follow up testing & updates for Xcode 16 and then will ship a new release.
Thank you @gui17aume and @Brett-Best !! |
attribute :platform_filters_by_relative_path, Hash | ||
|
||
def display_name | ||
"Exceptions for \"#{GroupableHelper.parent(self).display_name}\" folder in \"#{target.name}\" target" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason you have this explicit string here vs what Xcode itself generates here: PBXFileSystemSynchronizedBuildFileExceptionSet
Xcode replaces this string with that when editing the project file, so we're seeing a back-and-forth diff of this comment being edited by both parties.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked in Xcode 16.2RC and this string format is what is used on my projects still.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh I'm on 16.1, let me try 16.2 real quick to verify
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm Xcode 16.2 RC still reverts this comment:
- we're calling fastlane
increment_version_number_in_xcodeproj
, which just doesproject = Xcodeproj::Project.open
, edits a build setting, then doesproject.save
- this custom comment then gets added
- move a package/group/file in Xcode that is tracked in the project file
- the comment now becomes
PBXFileSystemSynchronizedBuildFileExceptionSet
This PR aims to support Xcode 16 project files and especially the new file system synchronized groups.
It is based on the work done by @Brett-Best in this other PR: #942 👍
Changes