Use a statically-linked runtime library #399
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, if the Visual C++ Redistributable isn't installed, the following error message pops up:
![image](https://private-user-images.githubusercontent.com/4129781/333798800-25185285-6888-421d-a7de-fc89c53d5f85.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzY1MjU0OTQsIm5iZiI6MTczNjUyNTE5NCwicGF0aCI6Ii80MTI5NzgxLzMzMzc5ODgwMC0yNTE4NTI4NS02ODg4LTQyMWQtYTdkZS1mYzg5YzUzZDVmODUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDExMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAxMTBUMTYwNjM0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OTBjZjkwZTZiNTM5Y2Y3MjA3NTE4NjQ0ZmFmMzlmODhjZmMwODBhMzllYWQwNjM4NDU3ZmJjNTZkOTNlOWQxMiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.jcwarsRXdR8JvVIyaM9I3fPSa-0fuMTwaoQSdA1cRtw)
This causes the binary size to increase by around 250 KB, e.g. for DebugViewConsole.exe it goes from 447 KB to 695 KB, but I believe that for such a tool, having it functional on any machine for troubleshooting etc. is more important.
BTW a statically-linked runtime library was used in v1.8, but was changed with the introduction of cmake.
Reference for the cmake command:
https://cmake.org/cmake/help/latest/variable/CMAKE_MSVC_RUNTIME_LIBRARY.html#variable:CMAKE_MSVC_RUNTIME_LIBRARY
Fixes #396.