Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back the population of the context.cardtitle for the pop-ups to solve #1003 #1089

Conversation

MrBearPresident
Copy link
Collaborator

@MrBearPresident MrBearPresident commented Dec 28, 2024

Breaking change

Proposed change

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

type: grid
cards:
  - type: vertical-stack
    cards:
      - type: custom:bubble-card
        card_type: button
        button_type: name
        show_icon: true
        icon: mdi:link
        name: Go To Sun Pop-up
        tap_action:
          navigation_path: "#Bubble-Test-Sun"
        button_action:
          tap_action:
            action: navigate
            navigation_path: "#Bubble-Test-Sun"
  - type: vertical-stack
    cards:
      - type: custom:bubble-card
        card_type: pop-up
        hash: "#Bubble-Test-Sun"
      - type: custom:bubble-card
        card_type: button
        button_type: state
        entity: sun.sun
    title: title

Example printscreens/gif

Before See #1003

Screen Recording 2024-12-28 213045

After

Screen Recording 2024-12-28 212837

Additional information

Additional documentation needed.

No

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests screenshots/gifs have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated for readme.

@MrBearPresident MrBearPresident changed the title - [x] Add back the population of the context.cardtitle for the pop-ups to solve #1003 Add back the population of the context.cardtitle for the pop-ups to solve #1003 Dec 28, 2024
@Clooos
Copy link
Owner

Clooos commented Dec 29, 2024

Thank you so much! You never stop! 😄

@Clooos Clooos merged commit 6571401 into Clooos:main Jan 7, 2025
2 checks passed
@MrBearPresident MrBearPresident deleted the 1003-bubble-card-titles-shown-on-dashboard branch January 7, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bubble card titles shown on dashboard
2 participants