Use p_vap_sat func in q_vap_sat #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #123 +/- ##
==========================================
- Coverage 93.88% 93.83% -0.05%
==========================================
Files 8 8
Lines 997 989 -8
==========================================
- Hits 936 928 -8
Misses 61 61
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
I've looked over this once more, and I realize now that we have correctness tests that cover this, so merging! |
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a small refactoring step towards #119. This PR:
saturation_vapor_pressureto allow users to provide a phase partitionsaturation_vapor_pressureis then called insideq_vap_saturation, whose contents were moved overThis mostly just deletes duplicate code. There is a bit of algebraic difference between the two, but I've confirmed that they're equivalent.