-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use local memory in band matrix solve #1735
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/bms_shmem
branch
from
May 20, 2024 14:28
6c2f363
to
84ee6ad
Compare
Main branch:
This branch:
So, a 2.37x speedup in Based on the device-side activity (on this branch):
It seems like the next step is to use a better (parallel) algorithm for the tridiagonal band matrix solve, to see if we can get better than ~1ms. |
charleskawczynski
force-pushed
the
ck/bms_shmem
branch
from
May 20, 2024 16:22
84ee6ad
to
46cc9c4
Compare
charleskawczynski
force-pushed
the
ck/bms_shmem
branch
4 times, most recently
from
May 21, 2024 18:31
841dd36
to
ff160c9
Compare
charleskawczynski
changed the title
Use shared memory in band matrix solve
Use local memory in band matrix solve
May 21, 2024
charleskawczynski
force-pushed
the
ck/bms_shmem
branch
from
May 21, 2024 18:51
ff160c9
to
aa4f0ac
Compare
charleskawczynski
force-pushed
the
ck/bms_shmem
branch
from
May 21, 2024 19:41
aa4f0ac
to
ebc41a1
Compare
charleskawczynski
force-pushed
the
ck/bms_shmem
branch
from
May 21, 2024 20:30
ebc41a1
to
9ac8a16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the use of local memory in the band matrix solve.
Closes #1738.