Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(wheelpicker): prevent android null isCyclic #140

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix(wheelpicker): prevent android null isCyclic #140

wants to merge 3 commits into from

Conversation

alexisrougnant
Copy link

@alexisrougnant alexisrougnant commented Nov 6, 2020 •
edited
Loading

Fix

On Android when isCyclic prop si not provided, if data.length > 2, the app crashes with a null exception on native side.

Screenshot 2020-11-06 at 10 54 23

Summary

Add a default value false to isCyclic for Android. WheelPicker.android.js is also converted to .tsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alexisrougnant