Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple fixes to uninstaller #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Multiple fixes to uninstaller #1

wants to merge 4 commits into from

Conversation

nicolas17
Copy link

Here's a bunch of fixes for the Ahorn uninstaller:

  • Delete folders in reverse order so that foo\bar\baz is deleted before foo\bar. Otherwise it tries to delete them before they're empty, which silently fails, and leaves thousands of empty folders around.
  • Add it correctly to Add/Remove Programs. Currently it isn't showing up there, so the only way to uninstall is to manually run uninstall.exe from the install directory.
  • Remove unnecessary quotes from the Add/Remove Programs information, and remove CelestialCartographers from the product name (it's already shown as the company name).

(None of this is worth a 0.0.4)

@nicolas17
Uninstaller: Fix directory deletion
02e90e2 
The uninstaller was removing directories in the same order as the
installer, which means it tried to remove parent directories before the
subdirectories inside, which failed because they weren't empty yet. This
left thousands of empty directories in the Ahorn installation.

By deleting the directories in reverse order, the uninstaller now deletes
subdirectories before their parents, which lets it delete everything.
@nicolas17
Fix showing uninstaller in "remove programs"
46dfcaf 
The uninstaller wasn't showing up in Add/Remove Programs because we were
trying to put the registry keys in HKEY_LOCAL_MACHINE, but the installer
isn't running as administrator so it had no permissions there.

Put the registry keys in HKEY_CURRENT_USER instead, which makes more sense
since we're installing in a user-local directory.
@nicolas17
Fix typo in uninstall confirmation
810381e
@nicolas17
Remove quotes from ARP registry keys
1fc15e2 
The registry keys for Add/Remove Programs had unnecessary quotes around the
values of DisplayName, Publisher, etc. which show up in the Add/Remove
Programs GUI.

I also removed COMPANYNAME from DisplayName, to make "Ahorn" be the first
word. The "company name" is shown elsewhere anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nicolas17